-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature SyntaxError
#536
Feature SyntaxError
#536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 68.10% 68.05% -0.06%
==========================================
Files 169 170 +1
Lines 9942 9957 +15
==========================================
+ Hits 6771 6776 +5
- Misses 3171 3181 +10
Continue to review full report at Codecov.
|
Benchmark for f21deb2Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of comments about the documentation :)
Benchmark for 89fd802Click to view benchmark
|
It changes the following:
SyntaxError
object.construct_syntax_error()
and.throw_syntax_error()
to_string()
(spec compliant and some cleanup)name
field inprototype
of error objects