-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Array.prototype.reduce #555
Implement Array.prototype.reduce #555
Conversation
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 68.19% 69.84% +1.65%
==========================================
Files 172 172
Lines 10573 10796 +223
==========================================
+ Hits 7210 7541 +331
+ Misses 3363 3255 -108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! check my comments on how to improve it :)
Co-authored-by: HalidOdat <halidodat@gmail.com>
2bbb231
to
b7655a2
Compare
…ngth modification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks for the contribution @benjaminflin :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, thanks! Could you check the second TypeError
message? Also, I would prefer if we added some tests for the error cases too.
I implemented
Array.prototype.reduce
according to the spec. Let me know if I missed anything as this is my first time contributing.