Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Array.prototype.reduceRight #579

Merged

Conversation

benjaminflin
Copy link
Contributor

I implemented Array.prototype.reduceRight pretty similarly to reduce, with a few small changes mostly related to usize constraints.

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #579 into master will increase coverage by 0.09%.
The diff coverage is 85.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   70.40%   70.50%   +0.09%     
==========================================
  Files         175      175              
  Lines       11162    11236      +74     
==========================================
+ Hits         7859     7922      +63     
- Misses       3303     3314      +11     
Impacted Files Coverage Δ
boa/src/builtins/array/mod.rs 80.66% <78.00%> (-0.31%) ⬇️
boa/src/builtins/array/tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a608a...174b162. Read the comment docs.

@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Jul 21, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Jul 21, 2020
@HalidOdat HalidOdat merged commit bbd7dd2 into boa-dev:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants