-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added keyword and operator colors and matching bracket validator to cli #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
enhancement
New feature or request
cli
Issues and PRs related to the Boa command line interface.
labels
Jul 23, 2020
HalidOdat
changed the title
Added keyword and operator colors and matching bracket validator
Added keyword and operator colors and matching bracket validator to cli
Jul 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
==========================================
- Coverage 71.13% 71.04% -0.09%
==========================================
Files 177 177
Lines 11425 11439 +14
==========================================
Hits 8127 8127
- Misses 3298 3312 +14
Continue to review full report at Codecov.
|
Benchmark for 1b9975eClick to view benchmark
|
HalidOdat
force-pushed
the
feature/cli-color
branch
from
July 23, 2020 19:28
1567a74
to
c83190e
Compare
Benchmark for 6bfe7ebClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #341 .
It changes the following:
"> "
to">> "
, looks much nicer ;)true
,false
,Infinity
) purple colorundefined
gray}
,)
,]
) so we can do something like:Example: some dummy code:
The line 5
undefined
is not colored because it is not part of the line that is being read, its output fromforward_val
BTW: we can change the colors at any time :)