-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy on Nightly #668
Fix clippy on Nightly #668
Conversation
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 71.76% 71.78% +0.02%
==========================================
Files 199 199
Lines 13953 13943 -10
==========================================
- Hits 10013 10009 -4
+ Misses 3940 3934 -6
Continue to review full report at Codecov.
|
Isn't it? I thought we had an specific test, that's odd. |
Oh there is. How come it was not failing for this lint ? Ok i am dumb i was running clippy on nightly and never tried it on stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but only once this is stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this as-is. The matches!()
macro is already stable, it's the lint the only thing that is unstable, so merging this would future-proof the project. What do everyone else think?
If @dvtkrlbs can resolve the merge conflict then I'm happy to merge this |
This PR just fixes clippy
It changes the following:
Ok i accidently tried this with nightly clippy and fixed a lint error for it. So this pr could be for nothing. But i can make it a draft PR and we can revisit it after this lint comes to the stable (if it ever does).