-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move value
module from builtins to root
#674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 194 194
Lines 14029 14029
=======================================
Hits 10266 10266
Misses 3763 3763
Continue to review full report at Codecov.
|
Benchmark for d4d7b9fClick to view benchmark
|
HalidOdat
force-pushed
the
move-value-module
branch
from
September 6, 2020 10:11
868a985
to
a543526
Compare
HalidOdat
added
API
builtins
PRs and Issues related to builtins/intrinsics
enhancement
New feature or request
labels
Sep 6, 2020
Benchmark for 2144d33Click to view benchmark
|
Razican
approved these changes
Sep 6, 2020
Lan2u
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
value
is inbuiltins
module, thebuiltins
module should be for builtin objects (Array, String, etc) and builtin properties.It changes the following:
value
module.I plan to move some other things that don't belong in
builtins
(likeproperty
)