Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move value module from builtins to root #674

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Move value module from builtins to root #674

merged 1 commit into from
Sep 7, 2020

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Sep 2, 2020

Currently the value is in builtins module, the builtins module should be for builtin objects (Array, String, etc) and builtin properties.

It changes the following:

  • Move value module.
  • Added pub export for Value this makes it easier since we do not specify the whole path.

I plan to move some other things that don't belong in builtins (like property)

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         194      194           
  Lines       14029    14029           
=======================================
  Hits        10266    10266           
  Misses       3763     3763           
Impacted Files Coverage Δ
boa/examples/classes.rs 0.00% <ø> (ø)
boa/src/builtins/array/mod.rs 76.60% <ø> (ø)
boa/src/builtins/bigint/conversions.rs 82.14% <ø> (ø)
boa/src/builtins/bigint/mod.rs 70.00% <ø> (ø)
boa/src/builtins/boolean/mod.rs 36.66% <ø> (ø)
boa/src/builtins/boolean/tests.rs 100.00% <ø> (ø)
boa/src/builtins/console/mod.rs 29.37% <ø> (ø)
boa/src/builtins/console/tests.rs 100.00% <ø> (ø)
boa/src/builtins/date/mod.rs 56.45% <ø> (ø)
boa/src/builtins/date/tests.rs 99.29% <ø> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76aba2a...a543526. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 2, 2020

Benchmark for d4d7b9f

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 388.4±21.69ns 394.8±48.30ns -1.62%
Arithmetic operations (Full) 277.4±16.87µs 274.2±15.72µs +1.17%
Array access (Execution) 9.1±0.52µs 8.9±0.56µs +2.25%
Array access (Full) 301.3±21.54µs 309.9±21.62µs -2.78%
Array creation (Execution) 3.3±0.15ms 3.5±0.17ms -5.71%
Array creation (Full) 3.8±0.20ms 3.7±0.18ms +2.70%
Array pop (Execution) 1192.2±75.12µs 1253.1±96.97µs -4.86%
Array pop (Full) 1637.5±85.74µs 1645.6±88.28µs -0.49%
Boolean Object Access (Execution) 5.3±0.42µs 5.4±0.36µs -1.85%
Boolean Object Access (Full) 300.1±21.79µs 300.6±22.00µs -0.17%
Clean js (Execution) 789.0±39.67µs 779.5±37.07µs +1.22%
Clean js (Full) 1116.1±71.78µs 1096.7±68.38µs +1.77%
Clean js (Parser) 40.1±2.55µs 39.5±2.39µs +1.52%
Create Realm 525.8±34.09ns 513.1±33.77ns +2.48%
Dynamic Object Property Access (Execution) 6.0±0.30µs 5.9±0.33µs +1.69%
Dynamic Object Property Access (Full) 301.8±18.48µs 303.6±24.64µs -0.59%
Expression (Parser) 7.4±0.46µs 7.3±0.96µs +1.37%
Fibonacci (Execution) 966.2±72.46µs 960.1±55.88µs +0.64%
Fibonacci (Full) 1245.5±75.97µs 1286.1±88.30µs -3.16%
For loop (Execution) 25.1±1.68µs 24.6±1.67µs +2.03%
For loop (Full) 335.1±39.27µs 323.2±22.19µs +3.68%
For loop (Parser) 19.9±1.25µs 19.2±0.90µs +3.65%
Goal Symbols (Parser) 12.9±0.76µs 12.8±0.82µs +0.78%
Hello World (Parser) 3.3±0.22µs 3.3±0.23µs 0.00%
Long file (Parser) 826.0±48.60ns 862.2±58.82ns -4.20%
Mini js (Execution) 701.3±38.93µs 701.8±33.00µs -0.07%
Mini js (Full) 1025.9±76.49µs 1005.5±63.36µs +2.03%
Mini js (Parser) 34.9±2.40µs 35.3±3.23µs -1.13%
Number Object Access (Execution) 4.2±0.30µs 4.2±0.29µs 0.00%
Number Object Access (Full) 289.8±17.34µs 294.9±27.91µs -1.73%
Object Creation (Execution) 5.2±0.32µs 5.2±0.45µs 0.00%
Object Creation (Full) 342.1±18.62µs 349.1±19.33µs -2.01%
RegExp (Execution) 79.4±5.68µs 77.2±6.06µs +2.85%
RegExp (Full) 381.6±20.30µs 380.7±29.32µs +0.24%
RegExp Literal (Execution) 79.8±9.58µs 79.6±6.27µs +0.25%
RegExp Literal (Full) 387.7±23.47µs 374.6±19.30µs +3.50%
RegExp Literal Creation (Execution) 73.3±4.61µs 74.1±5.18µs -1.08%
RegExp Literal Creation (Full) 456.1±29.68µs 456.2±25.09µs -0.02%
Static Object Property Access (Execution) 5.7±0.49µs 5.4±0.45µs +5.56%
Static Object Property Access (Full) 287.1±17.72µs 295.5±18.04µs -2.84%
String Object Access (Execution) 7.6±0.37µs 7.7±0.45µs -1.30%
String Object Access (Full) 296.8±24.38µs 295.5±17.99µs +0.44%
String comparison (Execution) 7.2±0.50µs 7.2±0.53µs 0.00%
String comparison (Full) 293.7±15.46µs 295.1±17.36µs -0.47%
String concatenation (Execution) 5.8±0.41µs 5.8±0.50µs 0.00%
String concatenation (Full) 297.1±19.77µs 292.5±19.68µs +1.57%
String copy (Execution) 4.5±0.25µs 4.2±0.27µs +7.14%
String copy (Full) 279.9±12.95µs 281.1±16.55µs -0.43%
Symbols (Execution) 3.6±0.21µs 3.6±0.26µs 0.00%
Symbols (Full) 276.9±47.15µs 270.1±43.18µs +2.52%

@HalidOdat HalidOdat added API builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Sep 6, 2020
@HalidOdat HalidOdat modified the milestones: v0.11.0, v0.10.0 Sep 6, 2020
@github-actions
Copy link

github-actions bot commented Sep 6, 2020

Benchmark for 2144d33

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 373.4±20.13ns 373.7±9.40ns -0.08%
Arithmetic operations (Full) 265.0±7.69µs 272.9±17.03µs -2.89%
Array access (Execution) 8.7±0.34µs 8.7±0.49µs 0.00%
Array access (Full) 293.9±14.01µs 288.9±8.47µs +1.73%
Array creation (Execution) 3.2±0.08ms 3.4±0.09ms -5.88%
Array creation (Full) 3.8±0.11ms 3.8±0.09ms 0.00%
Array pop (Execution) 1136.3±46.24µs 1194.9±55.71µs -4.90%
Array pop (Full) 1689.2±108.40µs 1686.1±47.81µs +0.18%
Boolean Object Access (Execution) 4.9±0.15µs 5.0±0.22µs -2.00%
Boolean Object Access (Full) 279.5±7.39µs 278.1±7.98µs +0.50%
Clean js (Execution) 759.7±51.80µs 774.1±32.78µs -1.86%
Clean js (Full) 1096.4±107.52µs 1117.1±50.58µs -1.85%
Clean js (Parser) 37.8±1.41µs 37.9±1.23µs -0.26%
Create Realm 482.6±34.55ns 474.9±18.74ns +1.62%
Dynamic Object Property Access (Execution) 5.8±0.18µs 5.7±0.39µs +1.75%
Dynamic Object Property Access (Full) 288.3±16.79µs 279.8±7.62µs +3.04%
Expression (Parser) 6.9±0.22µs 7.2±0.28µs -4.17%
Fibonacci (Execution) 909.8±26.82µs 917.2±29.90µs -0.81%
Fibonacci (Full) 1225.8±65.89µs 1233.3±41.95µs -0.61%
For loop (Execution) 24.5±1.55µs 24.1±1.36µs +1.66%
For loop (Full) 307.8±9.10µs 313.8±10.91µs -1.91%
For loop (Parser) 18.4±0.81µs 18.5±0.60µs -0.54%
Goal Symbols (Parser) 12.4±1.60µs 12.3±0.45µs +0.81%
Hello World (Parser) 3.2±0.14µs 3.3±0.14µs -3.03%
Long file (Parser) 812.5±37.03ns 819.5±63.16ns -0.85%
Mini js (Execution) 679.7±32.40µs 692.8±33.22µs -1.89%
Mini js (Full) 1000.3±65.29µs 1003.2±29.72µs -0.29%
Mini js (Parser) 33.3±0.81µs 33.7±2.19µs -1.19%
Number Object Access (Execution) 4.0±0.16µs 4.0±0.14µs 0.00%
Number Object Access (Full) 283.8±23.70µs 279.3±10.19µs +1.61%
Object Creation (Execution) 5.0±0.14µs 4.9±0.21µs +2.04%
Object Creation (Full) 334.9±20.00µs 338.1±15.20µs -0.95%
RegExp (Execution) 75.2±2.88µs 74.5±2.79µs +0.94%
RegExp (Full) 367.3±29.80µs 377.3±18.26µs -2.65%
RegExp Literal (Execution) 74.4±2.63µs 75.3±3.92µs -1.20%
RegExp Literal (Full) 376.4±90.92µs 375.5±26.91µs +0.24%
RegExp Literal Creation (Execution) 71.7±3.72µs 70.8±3.49µs +1.27%
RegExp Literal Creation (Full) 439.2±16.87µs 444.4±16.01µs -1.17%
Static Object Property Access (Execution) 5.2±0.16µs 5.2±0.29µs 0.00%
Static Object Property Access (Full) 281.0±9.73µs 280.9±13.59µs +0.04%
String Object Access (Execution) 7.2±0.26µs 7.3±0.20µs -1.37%
String Object Access (Full) 287.2±20.38µs 287.6±8.91µs -0.14%
String comparison (Execution) 6.8±0.25µs 6.6±0.39µs +3.03%
String comparison (Full) 282.8±9.61µs 287.3±13.27µs -1.57%
String concatenation (Execution) 5.6±0.38µs 5.6±0.22µs 0.00%
String concatenation (Full) 285.2±20.66µs 284.8±49.66µs +0.14%
String copy (Execution) 4.2±0.27µs 4.1±0.14µs +2.44%
String copy (Full) 272.0±9.98µs 276.7±37.01µs -1.70%
Symbols (Execution) 3.4±0.12µs 3.5±0.20µs -2.86%
Symbols (Full) 254.2±12.19µs 252.8±8.71µs +0.55%

@Lan2u Lan2u merged commit 59d328e into master Sep 7, 2020
@RageKnify RageKnify deleted the move-value-module branch January 3, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants