-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Object.defineProperties and handle props argument in Object.create #746
Conversation
I am looking for feedback on this. I might have missed some stuff since spec is kinda confusing |
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 59.15% 59.64% +0.49%
==========================================
Files 155 155
Lines 9841 9970 +129
==========================================
+ Hits 5821 5947 +126
- Misses 4020 4023 +3
Continue to review full report at Codecov.
|
Ok i think this is ready for review now. I know that i did not add any tests but i have no idea on how to test this. So i could use some help there |
@dvtkrlbs for a test you can look at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperties for an idea of how to test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding 1 test should be enough to improve the coverage values.
This Pull Request fixes/closes #552.
It changes the following: