Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for...in #750

Closed
wants to merge 1 commit into from
Closed

for...in #750

wants to merge 1 commit into from

Conversation

jasonwilliams
Copy link
Member

@jasonwilliams jasonwilliams commented Oct 1, 2020

  • BindingList no longer fails when followed by "in" or "of"

Initial start on ForIn

This Pull Request fixes/closes #670.

@jasonwilliams jasonwilliams changed the title BindingList no longer fails when followed by "in" or "of" for...in Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #750 into master will decrease coverage by 0.08%.
The diff coverage is 13.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage   71.75%   71.66%   -0.09%     
==========================================
  Files         200      200              
  Lines       13983    13999      +16     
==========================================
- Hits        10033    10032       -1     
- Misses       3950     3967      +17     
Impacted Files Coverage Δ
boa/src/syntax/ast/node/iteration.rs 51.88% <0.00%> (-9.92%) ⬇️
...syntax/parser/statement/iteration/for_statement.rs 62.79% <22.22%> (-12.21%) ⬇️
...src/syntax/parser/statement/declaration/lexical.rs 78.18% <66.66%> (+8.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83a03a...749fcfa. Read the comment docs.

@jasonwilliams
Copy link
Member Author

closing for now until for..of is looked at

@Razican
Copy link
Member

Razican commented Oct 8, 2020

Now that for...of loops have been implemented, I think we can give a look to this, right, @jasonwilliams ? Most of our panics in the test262 suite come from this: #817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement for..in for objects
2 participants