-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2 bugs that stopped test262 #812
Conversation
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
=======================================
Coverage 59.67% 59.68%
=======================================
Files 157 157
Lines 10052 10054 +2
=======================================
+ Hits 5999 6001 +2
Misses 4053 4053
Continue to review full report at Codecov.
|
There are other problems, working on them. |
On master it's
Its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, great work!
This Pull Request fixes the failure of test262 in CI by adding a check in
Array.prototype.map
and correctingArray.prototype.reduceRight
for length 1.It changes the following:
Array.prototype.map
now throws aRangeError
if thelength
of the received object is greater than 2^32 - 1, as per the spec.Array.prototype.reduceRight
now works correctly for length 1.