Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement spec compliant Array constructor #859

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Implement spec compliant Array constructor #859

merged 3 commits into from
Oct 15, 2020

Conversation

georgeroman
Copy link
Contributor

Fixes #816

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com labels Oct 14, 2020
@Razican Razican added this to the v0.11.0 milestone Oct 14, 2020
RageKnify
RageKnify suggested changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec asks for a lot of conversions to String which are unecessary and slow.

boa/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
@georgeroman
Copy link
Contributor Author

Addressed all comments.

@codecov
Copy link

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #859 into master will increase coverage by 0.06%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   59.08%   59.14%   +0.06%     
==========================================
  Files         164      164              
  Lines       10209    10224      +15     
==========================================
+ Hits         6032     6047      +15     
  Misses       4177     4177
Impacted Files Coverage Δ
boa/src/builtins/array/mod.rs 73.51% <85.18%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5e888...07c0e8c. Read the comment docs.

@RageKnify
Copy link
Contributor

@georgeroman sorry that you have to do this, but could you merge with current master so that all CI checks will pass please?

@georgeroman
Copy link
Contributor Author

Sure, no problem, just updated.

@RageKnify RageKnify merged commit e6a28e6 into boa-dev:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RageKnify RageKnify RageKnify approved these changes

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Lan2u Lan2u Awaiting requested review from Lan2u

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

The Array() constructor is not spec compliant
4 participants
@georgeroman @RageKnify @Razican @HalidOdat