Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of Array-related panics #919

Merged
merged 15 commits into from
Dec 15, 2020
Merged

Reduce the number of Array-related panics #919

merged 15 commits into from
Dec 15, 2020

Commits on Oct 29, 2020

  1. Use to_length when accessing array length in Array module

    @jakubfijalkowski
    jakubfijalkowski committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    fadd046 View commit details
    Browse the repository at this point in the history

  2. Change stray length cast to to_length

    @jakubfijalkowski
    jakubfijalkowski committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    8dcf6c3 View commit details
    Browse the repository at this point in the history

  3. Handle +/-Inf and NaNs in array functions 

    It still needs some work to handle the cases correctly, but doesnt't
panic now
    @jakubfijalkowski
    jakubfijalkowski committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    03af456 View commit details
    Browse the repository at this point in the history

  4. Collapse the collapsible else-if statement

    @jakubfijalkowski
    jakubfijalkowski committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    7b1fc2c View commit details
    Browse the repository at this point in the history

  5. Reformat array module

    @jakubfijalkowski
    jakubfijalkowski committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    5b4a973 View commit details
    Browse the repository at this point in the history

  6. Fix the variable names post-rebase

    @jakubfijalkowski
    jakubfijalkowski committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c0e02d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Use safe casts instead of as

    @jakubfijalkowski
    jakubfijalkowski committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    2c75c0a View commit details
    Browse the repository at this point in the history

  2. Fix the fill function

    @jakubfijalkowski
    jakubfijalkowski committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    6365cf3 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. Implement to_integer_or_infinity from the ECMA spec and use it in `… 

    …fill` and `slice`
    @jakubfijalkowski
    jakubfijalkowski committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    a86ea85 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. Use i64 as ToIntegerOrInfinity inner type & move `as_relative_sta… 

    …rt` and `as_relative_end` to array module
    @jakubfijalkowski
    jakubfijalkowski committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8fb83b0 View commit details
    Browse the repository at this point in the history

  2. Remove the From<TryFromIntError> impl from Value

    @jakubfijalkowski
    jakubfijalkowski committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    44586a9 View commit details
    Browse the repository at this point in the history

  3. Rename the err_to_value helper function

    @jakubfijalkowski
    jakubfijalkowski committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    7632e91 View commit details
    Browse the repository at this point in the history

  4. Reformat code and fix Clippy errors

    @jakubfijalkowski
    jakubfijalkowski committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8a128bb View commit details
    Browse the repository at this point in the history

  5. Fix tests and improve the casts in get_relative_* a little

    @jakubfijalkowski
    jakubfijalkowski committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    de447ca View commit details
    Browse the repository at this point in the history

  6. Reformat the code once again

    @jakubfijalkowski
    jakubfijalkowski committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    bbecaf3 View commit details
    Browse the repository at this point in the history