Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and more implementation #110

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Bug fixes and more implementation #110

merged 2 commits into from
Nov 26, 2024

Conversation

jasonwilliams
Copy link
Member

  • md_record from parse_ixdtf is enough, we shouldn't need to fall back to datetime parsing.
  • from_str should lowercase the iso8601 (fixes tests)
  • Support parsing the ISO string then getting the calendar from that.
  • Support ref year

This is to support changes in boa-dev/boa#4034

@jasonwilliams
- md_record from parse_ixdtf is enough, we shouldn't need to fall bac…
211280a 
…k to datetime parsing.

- from_str should lowercase the iso8601 (fixes tests)
- Support parsing the ISO string then getting the calendar from that.
- Support ref year
@jasonwilliams jasonwilliams merged commit 454d1a8 into main Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonwilliams @jedel1043 @nekevss