Implement Duration::round and some general updates/fixes
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
force-pushed
the
duration-update
branch
from
a974d4a
to
f0d1e6c
Compare
nekevss
changed the title
Duration::round and some general updatesDuration::round and some general updates/fixes
nekevss
force-pushed
the
duration-update
branch
from
90355f6
to
94d3966
Compare
jedel1043
reviewed
Feb 25, 2024
jedel1043
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a WIP.EDIT: this is ready for review!
This PR is to implement
Duration::roundalong with some other updates and ideally basic tests as well. The hope is to have this implemented and tested so that it can be used to switch over the internal duration slots fromf64toi32. 😄A couple notes:
round.floorrounding, but this can be added to if desired.