Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non_exhaustive attribute to component structs #25

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Add non_exhaustive attribute to component structs #25

merged 1 commit into from
Feb 24, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 23, 2024

Updates public facing structs to have a #[non_exhaustive] attribute flag so that components cannot be constructed with a StructExpression.

@nekevss nekevss added this to the 0.1 Blocking milestone Feb 24, 2024
jasonwilliams
jasonwilliams approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss nekevss merged commit a32940f into main Feb 24, 2024
5 checks passed
@jedel1043 jedel1043 deleted the api-update branch February 24, 2024 23:29
@jedel1043 jedel1043 added the C-enhancement New feature or request label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@jedel1043 jedel1043 Awaiting requested review from jedel1043

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
0.1 Blocking
Development

Successfully merging this pull request may close these issues.
3 participants
@nekevss @jasonwilliams @jedel1043