Setup publish CI #26
Merged
Setup publish CI #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
reviewed
Feb 25, 2024
cliff.toml
Outdated
| # parse the commits based on https://www.conventionalcommits.org | ||
| conventional_commits = false | ||
| # filter out the commits that are not conventional | ||
| filter_unconventional = true |
There was a problem hiding this comment.
question: This should probably be false for now, right?
So far commits have not used conventional commits (although, maybe we should use them but that's a different discussion), and this filters any commits that have not used conventional commits, which would be everything.
There was a problem hiding this comment.
True! I don't know why cliff generates the default template like this (I picked the Github template), but I'll set this to false just in case.
nekevss
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we could think about using release-plz in the future, but this should suffice for now.