Small parser refactor / cleanup #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
approved these changes
Feb 29, 2024
| if !(0..=23).contains(&hour_value) { | ||
| return Err(TemporalError::syntax().with_message("Hour must be in a range of 0-23")); | ||
| } | ||
| Ok(hour_value) | ||
| } | ||
|
|
||
| // NOTE: `TimeSecond` is a 60 inclusive `MinuteSecond`. | ||
| /// Parse `MinuteSecond` | ||
| /// Parse `MinuteSecond` value. |
There was a problem hiding this comment.
Can you link to the corresponding grammar rule?
There was a problem hiding this comment.
Can do. Better documentation all the way around is definitely needed. Should we update the grammar rules as a whole in a follow-up PR or do you mind if I add them in on this PR?
There was a problem hiding this comment.
If you plan on doing a PR only for documentation, you can postpone this change for that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines some of the ISO8601 parsing and removes unnecessary iterations.