Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parsing throws with unknown critical annotations #63

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

jedel1043
Copy link
Member

No description provided.

@jedel1043 jedel1043 added C-bug Something isn't working C-internal Internal library improvements labels Jun 25, 2024
// Ignore all invalid annotations
None
// Make the parser handle any unknown annotation.
Some(annotation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah shoot! Nice catch.

@jedel1043 jedel1043 merged commit ec2f2d0 into main Jun 25, 2024
5 checks passed
@jedel1043 jedel1043 deleted the handle-invalid-annotations branch June 25, 2024 18:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working C-internal Internal library improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants