Implement add and subtract methods for Duration #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
reviewed
Jul 7, 2024
src/components/duration.rs
Outdated
| /// Returns the result of adding a `Duration` to the current `Duration` | ||
| #[inline] | ||
| pub fn add(&self, other: &Self) -> TemporalResult<Self> { | ||
| self.internal_add(other) |
There was a problem hiding this comment.
Nit: do we need to have an internal_add method? I think it would be cleaner to move the code of internal_add to add, then just call self.add(other.negated()) for subtract.
jedel1043
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ongoing work for #11
As it says in the title, implementing the add and subtract methods for duration.