Add file type option which ignores file extensions other than provided #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhirsz
reviewed
Jul 2, 2020
|
|
||
| .resource And .tsv Supported File Types | ||
| [Template] Run Rflint And Verify There Are No Errors For Supported File Types | ||
| resource tsv |
There was a problem hiding this comment.
I did it on purpose, please look at the whole file. But I can revert it if it looks strange. What do you think?
There was a problem hiding this comment.
Oh I see, thanks to this format it's easy to see that you're testing this or that file format combination. But maybe you could use this approach?
*** Test Cases ***
Test Supported File Types
[Template] Run Rflint And Verify There Are No Errors For Supported File Types
robot resource tsv
robot resource
resource tsv
robot tsv
robot
resource
There was a problem hiding this comment.
Yeah, another approach is to use arguments embedded in keyword name. I will think which one is the best for this use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently RFlint operates on .robot, .resource, .txt and .tsv file extensions but in RF 3.2 all extensions different than .robot and .resource. are not automatically supported (you need to provide them explicitly). There is also a file type .rst that RF supports but RFLint does not read it. By adding new command line option the user is able to select which file types will be processed and RFlint will ignore the others. The default supported files are .robot and .resource but you can also provide .txt, .tsv and .rst extensions.
The option is called by --filetypes or -t with extensions separated by comma, e.g. rflint -t robot,resource,txt
I added also test cases to cover this new feature.