Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable merging PDF outlines (aka bookmarks) #70

Merged
merged 10 commits into from
Jul 4, 2016

Conversation

sLe1tner
Copy link
Contributor

@sLe1tner sLe1tner commented Jul 4, 2016

Hey Bo,
I think we might be done, finally :)

I made one more small change:
The way the position used to get checked, resulted in inserted outlines always being at the start unless the inserted PDF file was appended to the end. I just switched that, to be the other way around, so now the inserted outline will always be appended to the end, unless a PDF gets inserted at the start, then it's outline will also be inserted at the beginning.
That just feels right, compared to how it worked before, in my opinion.

I left the method I used for printing the hash to a file in there because I thought it might be useful for anyone who decides to work on the outlines hash in the future..

Also, I may have gone a bit overboard on documenting that merge method..

@boazsegev
Copy link
Owner

Thank you so much, I'm excited to test this out!
👍🏻💛💚💙💚💛

P.S.

As to the begging/ending logic, I like the new logic better.

And since I'm bad at documenting, I'm happy you took the time. Wordiness is sometimes better then obscurity.

@boazsegev boazsegev merged commit 4426797 into boazsegev:master Jul 4, 2016
@boazsegev
Copy link
Owner

I added a line in the copyright statement (the license file). Remove / edit at your discretion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants