Enable merging PDF outlines (aka bookmarks) #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Bo,
I think we might be done, finally :)
I made one more small change:
The way the position used to get checked, resulted in inserted outlines always being at the start unless the inserted PDF file was appended to the end. I just switched that, to be the other way around, so now the inserted outline will always be appended to the end, unless a PDF gets inserted at the start, then it's outline will also be inserted at the beginning.
That just feels right, compared to how it worked before, in my opinion.
I left the method I used for printing the hash to a file in there because I thought it might be useful for anyone who decides to work on the outlines hash in the future..
Also, I may have gone a bit overboard on documenting that merge method..