Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Fizzie deliver oik-custom.css? #57

Closed
bobbingwide opened this issue Apr 7, 2021 · 1 comment
Closed

Should Fizzie deliver oik-custom.css? #57

bobbingwide opened this issue Apr 7, 2021 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Apr 7, 2021

I noticed in my development environment that the oik custom CSS file was specified as oik-custom.css but was not present and produced a 404 in the Chrome console.

In live ( blocks.wp-a2z.org) this problem didn't occur.

It turns out this was part of oik's logic to decide whether or not to enqueue the file based on the timestamp of the file.
It's affected by te value of WP_DEBUG.

When false, as it was in development, then an attempt is made to load the file if specified.
When true, as it is in live, the it's only loaded if present.

I think the answer is "No, don't deliver oik-custom.css, or custom.css for that matter. It's not needed".

@bobbingwide bobbingwide added the question Further information is requested label Apr 7, 2021
@bobbingwide bobbingwide self-assigned this Apr 7, 2021
@bobbingwide
Copy link
Owner Author

delivered in v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant