Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color settings no longer what I expect them to be #19

Open
bobbingwide opened this issue Oct 3, 2019 · 5 comments
Open

Color settings no longer what I expect them to be #19

bobbingwide opened this issue Oct 3, 2019 · 5 comments
Assignees
Labels

Comments

@bobbingwide
Copy link
Owner

I updated to Genesis 3.1.2 and did some other things and now my colour settings have gone all blue. Why?
image

@bobbingwide bobbingwide added the bug label Oct 3, 2019
@bobbingwide bobbingwide self-assigned this Oct 3, 2019
@bobbingwide
Copy link
Owner Author

Fortunately, if I don't change a paragraph block that does have a (what was) valid value for a background colour then the front end is still OK.
Colours I'd used are: light-green-cyan, luminous-vivid-orange, luminous-vivid-amber and none selected... which means that the padding is lost.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Oct 3, 2019

Note: The genesis-hm theme is correctly displaying the colours I'd selected for that ( s.b/hm )
image

And the genesis-oik theme is showing the original colour set (s.b/oikcom and s.b/wordpress )
image

So it should be an easy task to find out what's gone wrong.

In all sites, the parent theme is Genesis 3.1.2

@bobbingwide
Copy link
Owner Author

bobbingwide commented Oct 3, 2019

I know where the main bug was introduced. If I revert to v1.3.0 then the palette returns to normal.

... Except Vivid Purple is missing. 11 colours rather than 12.
Now I want to know where that's gone?
Answer: This new colour was added in Gutenberg 6.3.
See WordPress/gutenberg#16833

@bobbingwide
Copy link
Owner Author

bobbingwide commented Oct 3, 2019

It would appear that the default editor-color-palette array is not available in core PHP code. The Kadence blocks plugin builds its own default array in Kadence_Blocks_Settings::load_color_palette
So I'll copy and cobble that.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Oct 3, 2019

I'm also going to add "White". I can kill two birds with one stone here.

  1. When selected as the Text colour it'll provide better contrast than Light grey.
  2. When selected as a Background colour the block will gain the extra padding associated with the has-background class.
.editor-styles-wrapper p.has-background {
    padding: 25px 30px;
}

This will potentially resolve a problem I've encountered on the home page where text styled with a white background is obviously different.

The downside is that the "color combination" warning can appear where it previously didn't... even though the background colour was by default white.
image

And we can only wonder what those two messages about backups and autosaves I should believe.

bobbingwide added a commit that referenced this issue Oct 3, 2019
…olours, plus Vivid Purple, White and the Link and Accent colours set by the user in the Customizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant