Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Parser panic when runner reports cpu #49

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

piotrekmonko
Copy link
Contributor

Some Github runners report, in addition to and after pkg: line, also the CPU name on which the benchmarks are run which results in a panic which this proposed PR fixes:

panic: cpu: Intel(R) Xeon(R) Platinum 8275CL CPU @ 3.00GHz: could not parse run: strconv.Atoi: parsing "": invalid syntax (line: cpu: Intel(R) Xeon(R) Platinum 8275CL CPU @ 3.00GHz)

@piotrekmonko
Copy link
Contributor Author

This fixes issue #47

Copy link
Owner

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, thank you!

@bobheadxi
Copy link
Owner

Closes #48

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #49 (56788e6) into master (45436a7) will decrease coverage by 1.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   32.65%   31.30%   -1.34%     
==========================================
  Files           8        8              
  Lines         481      441      -40     
==========================================
- Hits          157      138      -19     
+ Misses        306      285      -21     
  Partials       18       18              
Impacted Files Coverage Δ
bench/parser.go 63.24% <100.00%> (+0.57%) ⬆️
checks/config.go 59.10% <0.00%> (-2.44%) ⬇️
io.go 9.90% <0.00%> (-1.99%) ⬇️
checks/evaluate.go 69.39% <0.00%> (-0.98%) ⬇️
main.go 0.00% <0.00%> (ø)
merge.go 0.00% <0.00%> (ø)
checks/generate.go 0.00% <0.00%> (ø)
bench/benchmark.go 50.00% <0.00%> (+7.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45436a7...56788e6. Read the comment docs.

@bobheadxi bobheadxi merged commit 346f8bc into bobheadxi:master Oct 30, 2021
@bobheadxi bobheadxi mentioned this pull request Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip stdout which is not benchmark result, or provide better error message
2 participants