Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: print and exit instead of panic on error, improve benchmark read failure error #52

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

bobheadxi
Copy link
Owner

Closes #51

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #52 (8466bda) into master (b37e8fd) will decrease coverage by 0.43%.
The diff coverage is 11.63%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   31.30%   30.87%   -0.42%     
==========================================
  Files           8        8              
  Lines         441      460      +19     
==========================================
+ Hits          138      142       +4     
- Misses        285      302      +17     
+ Partials       18       16       -2     
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
bench/parser.go 69.12% <100.00%> (+5.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37e8fd...8466bda. Read the comment docs.

@bobheadxi bobheadxi changed the title cli: print and exit instead of panic on error cli: print and exit instead of panic on error, improve benchmark read failure error Apr 27, 2022
@bobheadxi bobheadxi merged commit a8dc446 into master Apr 27, 2022
@bobheadxi bobheadxi deleted the no-panic branch April 27, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing of benchmark results with panic/timeout causes another panic
1 participant