Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: fix evaluation against latest run in base #71

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

bobheadxi
Copy link
Owner

Evaluation currently takes the oldest run, not the latest 😬 Closes #70

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 30.32% // Head: 30.19% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (ec928b4) compared to base (c898384).
Patch coverage: 66.67% of modified lines in pull request are covered.

❗ Current head ec928b4 differs from pull request most recent head e25e068. Consider uploading reports for the commit e25e068 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   30.32%   30.19%   -0.12%     
==========================================
  Files           9        9              
  Lines         475      477       +2     
==========================================
  Hits          144      144              
- Misses        315      316       +1     
- Partials       16       17       +1     
Impacted Files Coverage Δ
checks/evaluate.go 67.35% <50.00%> (-2.04%) ⬇️
bench/benchmark.go 58.34% <100.00%> (+8.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bobheadxi bobheadxi merged commit e219e63 into main Jan 12, 2023
@bobheadxi bobheadxi deleted the checks-against-latest-benchmark branch January 12, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checks always compare against first recorded benchmark
1 participant