Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Javadoc-style comments #14

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

Relm-Arrowny
Copy link
Contributor

Added Javadoc-style comments for all the public functions and looking at here, I think doxygen has extract_private set to off so I have not add any comments on any of the private functions.

I have not change any of the code but I have tested it still compile and pass all test.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thank you for creating your first pull-request on the Graaf library :)

Copy link
Owner

@bobluppes bobluppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for picking this up! LGTM, thanks for your contribution 🚀

Tagging #11 as this PR addresses part of the issue.

@bobluppes bobluppes merged commit 080511e into bobluppes:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants