-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Unweighted shortest path #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Thank you for creating your first pull-request on the Graaf library :)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
===========================================
- Coverage 100.00% 99.80% -0.20%
===========================================
Files 9 12 +3
Lines 411 518 +107
===========================================
+ Hits 411 517 +106
- Misses 0 1 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, looks very good already! Added some early feedback.
I would also be happy to merge the BFS implementation and to add support for weighted graph search in a follow-up PR.
@bobluppes any idea why codecov does not catch the closing curly bracket here? Building and testing runs flawlessly |
This seems to be a weird quirck of Currently the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, thanks for implementing this 🚀
Value add: