Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE 87: vf2 algorithm refactor #185
ISSUE 87: vf2 algorithm refactor #185
Changes from 11 commits
88e416f
961c455
51c20a2
ac10f06
6f62549
7c41e14
6276f24
f8d7978
208b5b1
d31bd22
6cab701
b2196fc
71e91f9
8169a25
8366090
4bc5d2c
019c399
03c1676
667673f
be8b0a9
2a876bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 56 in include/graaflib/algorithm/graph_isomorphism.tpp
Codecov / codecov/patch
include/graaflib/algorithm/graph_isomorphism.tpp#L56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this name is quite verbose. What about
vertex_neighbors
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand it is verbose, but for someone who has an idea of how the algorithm works, this name is pretty descriptive and says exactly what the struct is for. I would like to keep this as the name, if you would allow it.