Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor path reconstruction for shortest path #43

Merged
merged 4 commits into from
Jul 29, 2023

Conversation

joweich
Copy link
Collaborator

@joweich joweich commented Jul 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18% 🎉

Comparison is base (860978c) 99.51% compared to head (0f53e5c) 99.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   99.51%   99.70%   +0.18%     
==========================================
  Files          22       22              
  Lines        1038     1025      -13     
==========================================
- Hits         1033     1022      -11     
+ Misses          5        3       -2     
Files Changed Coverage Δ
include/graaflib/algorithm/shortest_path.h 100.00% <ø> (ø)
include/graaflib/algorithm/shortest_path.tpp 100.00% <100.00%> (+3.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobluppes bobluppes self-requested a review July 29, 2023 09:51
Copy link
Owner

@bobluppes bobluppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor, I like 👍🏻
Just some smaller ideas for further improvement

include/graaflib/algorithm/shortest_path.h Outdated Show resolved Hide resolved
include/graaflib/algorithm/shortest_path.tpp Outdated Show resolved Hide resolved
@bobluppes
Copy link
Owner

Very nice, LGTM 🚀

@bobluppes bobluppes merged commit a25ae1b into bobluppes:main Jul 29, 2023
@joweich joweich deleted the refactor/path-reconstruction branch July 29, 2023 12:04
@bobluppes bobluppes added the refactor A change which does not change any behavior label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A change which does not change any behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants