Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooling: Benchmark visualization script #46

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Conversation

bobluppes
Copy link
Owner

@bobluppes bobluppes commented Jul 30, 2023

This PR adds a python script under tools/, which can be used to visualize google benchmark data. An example plot can be found below.

Not very familiar with python, so any improvement suggestions are more than welcome.

vertex

@bobluppes bobluppes requested a review from joweich July 30, 2023 15:46
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9fdce58) 99.70% compared to head (802180a) 99.70%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          22       22           
  Lines        1025     1025           
=======================================
  Hits         1022     1022           
  Misses          3        3           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@joweich joweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobluppes Bear with me, I've been very picky with my comments. In general, I think there are some low hanging opportunities to make the code more python-idiomatic. Happy to give it a shot and add my proposal to this PR!

tools/benchmark_visualization.py Outdated Show resolved Hide resolved
tools/benchmark_visualization.py Outdated Show resolved Hide resolved
tools/benchmark_visualization.py Outdated Show resolved Hide resolved
tools/benchmark_visualization.py Outdated Show resolved Hide resolved
tools/benchmark_visualization.py Show resolved Hide resolved
@joweich joweich self-requested a review July 30, 2023 21:29
Copy link
Collaborator

@joweich joweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's definitely still some potential for additional checks and capabilities, esp. automatic inference of skiprows, but I think it's fine for now.

@bobluppes
Copy link
Owner Author

There's definitely still some potential for additional checks and capabilities, esp. automatic inference of skiprows, but I think it's fine for now.

Thanks for improving this, it looks much more pythonic now 🐍

Added a very minor change such that we can now glob subdirectories as I just changed to the following build layout

build
 |_ Debug
 |_ Release

@bobluppes bobluppes merged commit 8f5236d into main Aug 4, 2023
@bobluppes bobluppes deleted the benchmark-visualization branch August 4, 2023 21:55
@bobluppes bobluppes added the tooling Any changes to the build process, dev tools, or CI steps label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Any changes to the build process, dev tools, or CI steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants