-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tooling: Benchmark visualization script #46
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 22 22
Lines 1025 1025
=======================================
Hits 1022 1022
Misses 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobluppes Bear with me, I've been very picky with my comments. In general, I think there are some low hanging opportunities to make the code more python-idiomatic. Happy to give it a shot and add my proposal to this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's definitely still some potential for additional checks and capabilities, esp. automatic inference of skiprows
, but I think it's fine for now.
Thanks for improving this, it looks much more pythonic now 🐍 Added a very minor change such that we can now glob subdirectories as I just changed to the following build layout
|
This PR adds a python script under
tools/
, which can be used to visualize google benchmark data. An example plot can be found below.Not very familiar with python, so any improvement suggestions are more than welcome.