Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking-change: Separate concerns weightedness and directedness #48

Merged
merged 6 commits into from
Aug 5, 2023

Conversation

bobluppes
Copy link
Owner

This PR separates the concerns between weightedness of edges and directedness of graphs.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (9a62679) 99.80% compared to head (b400021) 99.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   99.80%   99.80%   -0.01%     
==========================================
  Files          22       22              
  Lines        1025     1011      -14     
==========================================
- Hits         1023     1009      -14     
  Misses          2        2              
Files Changed Coverage Δ
include/graaflib/algorithm/shortest_path.h 100.00% <ø> (ø)
include/graaflib/types.h 100.00% <ø> (ø)
test/graaflib/algorithm/cycle_detection_test.cpp 100.00% <ø> (ø)
test/graaflib/algorithm/graph_traversal_test.cpp 100.00% <ø> (ø)
test/graaflib/algorithm/shortest_path_test.cpp 100.00% <ø> (ø)
test/graaflib/graph_traits_test.cpp 100.00% <ø> (ø)
...est/graaflib/properties/vertex_properties_test.cpp 100.00% <ø> (ø)
include/graaflib/algorithm/cycle_detection.tpp 95.34% <100.00%> (ø)
include/graaflib/algorithm/graph_traversal.tpp 100.00% <100.00%> (ø)
include/graaflib/algorithm/shortest_path.tpp 100.00% <100.00%> (ø)
... and 12 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobluppes bobluppes changed the title refactor: Separate concerns weightedness and directedness breaking-change: Separate concerns weightedness and directedness Aug 5, 2023
@bobluppes bobluppes marked this pull request as ready for review August 5, 2023 20:43
@bobluppes bobluppes merged commit 7bd1094 into main Aug 5, 2023
@bobluppes bobluppes deleted the refactor branch August 5, 2023 21:00
@bobluppes bobluppes added breaking-change A change which changes the public API refactor A change which does not change any behavior labels Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A change which changes the public API refactor A change which does not change any behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant