Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking-change: Report traversed edges instead of vertices #64

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

bobluppes
Copy link
Owner

This PR addresses #63.

Instead of reporting the traversed vertices in breadth_first_traverse and depth_first_traverse, we report the traversed edges.

In a follow up I would make a similar change to the shortest path algorithms, as a path given by a range of edges is more usable. See our current shortest path example.

@bobluppes bobluppes added enhancement New feature breaking-change A change which changes the public API labels Aug 7, 2023
@bobluppes bobluppes self-assigned this Aug 7, 2023
@bobluppes
Copy link
Owner Author

FYI @Hromz

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (8348b33) 99.81% compared to head (ec33941) 99.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files          22       22              
  Lines        1081     1076       -5     
==========================================
- Hits         1079     1074       -5     
  Misses          2        2              
Files Changed Coverage Δ
include/graaflib/algorithm/graph_traversal.tpp 100.00% <100.00%> (ø)
test/graaflib/algorithm/graph_traversal_test.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobluppes bobluppes merged commit b4f9e10 into main Aug 7, 2023
@bobluppes bobluppes deleted the traversal-callback-signature branch August 7, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A change which changes the public API enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant