Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Catch negative edge weights in tree-version dijkstra #71

Merged

Conversation

joweich
Copy link
Collaborator

@joweich joweich commented Aug 13, 2023

Complementary to #67.

Note that I again used std::format, which I see to be removed in the whole codebase in a follow-up PR.

@joweich joweich requested a review from bobluppes August 13, 2023 13:30
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bbd7e90) 99.73% compared to head (e85b94d) 99.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   99.73%   99.74%           
=======================================
  Files          23       23           
  Lines        1149     1158    +9     
=======================================
+ Hits         1146     1155    +9     
  Misses          3        3           
Files Changed Coverage Δ
include/graaflib/algorithm/shortest_path.tpp 100.00% <100.00%> (ø)
test/graaflib/algorithm/shortest_path_test.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@bobluppes bobluppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

I have created #72 to keep track of removing fmt. Feel free to pick it up if you want to, otherwise I can take a look next week.

@bobluppes bobluppes added the enhancement New feature label Aug 13, 2023
@bobluppes bobluppes merged commit b8bd54e into bobluppes:main Aug 13, 2023
@joweich joweich deleted the enhancement/dijkstra_tree_negative_edges branch August 13, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants