Not working after upgrading to PHP 7.3 #540

dportalesr · 2018-12-08T13:47:59Z

After upgrading PHP to 7.3.0 - latest version (and Xdebug to 2.7.0beta1 latest version compatible with PHP 7.3, in case it matters), tinker is no longer working. It launches correctly but I after I input a command it just exits with no error, nothing written to log file and status code 0.

laravel/tinker#63

I can confirm it's happening to me as well. Any input closes the REPL, no errors or messages at all.

Any ideas about how to proceed? Thanks.

GrahamCampbell · 2018-12-08T14:31:27Z

Does it work after uninstalling xdebug?

GrahamCampbell · 2018-12-08T14:32:00Z

xdebug 2.7.0beta1 is not actually compatible fully with php 7.3 yet. No release or even master of xdebug fully works yet.

dciancu · 2018-12-08T14:33:00Z

@GrahamCampbell It doesn't work with xdebug disabled either

dciancu · 2018-12-08T14:33:32Z

xdebug works very well with php 7.3 from what I have tested, had no issue with it.

GrahamCampbell · 2018-12-08T14:33:34Z

Does it work after full uninstallation of the plugin, not just disabling?

GrahamCampbell · 2018-12-08T14:34:01Z

xdebug works very well with php 7.3 from what I have tested, has no issue with it.

There are various known issues documented on xdebug's github, including a failing test suite.

dciancu · 2018-12-08T14:34:10Z

@GrahamCampbell not disabled by xdebug.enable, but removed from php.ini I meant

dportalesr · 2018-12-09T01:03:56Z

Apparently Xdebug added support for PHP 7.3 recently
https://bugs.xdebug.org/view.php?id=1519
xdebug/xdebug#430

As @GrahamCampbell mentions there are still a couple of issues in their tracker. Not sure how to generate a report of this problem for them.

chapeupreto · 2018-12-09T14:24:00Z

I have a fresh PHP7.3 install (brew install php@7.3) with no xdebug and that very same problem is happening to me as well:

bobthecow · 2018-12-09T15:19:19Z

Update: as discussed below, this is a bug in Homebrew/macOS/PHP/pcntl. It should really be worked around by disabling pcre.jit in your php.ini.

It has something to do with forking / pcntl. I'm trying to sort it out.

~~In the meantime, you can use PsySH by disabling pcntl support, by adding this to your config file:~~

// really, don't do this. disable it in php.ini :)
return [
  'usePcntl' => false, 
];

bobthecow · 2018-12-10T06:56:08Z

Ok, got it!

Homebrew-installed PHP 7.3.0 on Mojave segfaults when calling preg_match from a child process.

Repro:

<?php

if (preg_match('/./', 'a')) echo "pre-fork works\n";

$pid = pcntl_fork();
if ($pid == -1) {
    die('fail');
} elseif ($pid) {
    if (preg_match('/./', 'a')) echo "parent works\n";
    pcntl_wait($status);
    if (pcntl_wifsignaled($status) && pcntl_wtermsig($status) == SIGSEGV) {
        die('child process segfaulted');
    }
} else {
    if (preg_match('/./', 'a')) echo "child works\n";
}

In PHP < 7.3, this results in:

pre-fork works
parent works
child works

But in PHP 7.3, we get:

pre-fork works
parent works
child process segfaulted

I'm not sure what the extent of this issue is. 3v4l.org doesn't have PCNTL so we can't test there. All versions of PHP that Travis tests worked. That said, Travis is testing RC3, so it might be a bug introduced between that and the stable release?

Are y'all on Homebrew + Mojave? Can anyone repro this with other PHP 7.3 versions or sources or operating systems?

dportalesr · 2018-12-10T07:14:10Z

Are y'all on Homebrew + Mojave?

Yeah.

ghost · 2018-12-10T09:20:15Z

Same here, Homebrew and Mojave without xdebug installed.

chapeupreto · 2018-12-10T10:39:42Z

Just to let you know: same problem with PHP7.3 running on macOS High Sierra

bobthecow · 2018-12-10T15:20:10Z

Just to let you know: same problem with PHP7.3 running on macOS High Sierra

Also installed via Homebrew?

chapeupreto · 2018-12-10T15:31:40Z

Just to let you know: same problem with PHP7.3 running on macOS High Sierra

Also installed via Homebrew?

Yes!

CQD · 2018-12-10T16:15:46Z

Ubuntu 16.04 + PHP 7.3 (ppa:ondre/php) + psysh 0.9.9 works fine.

No segfault when running #540 (comment)

bobthecow · 2018-12-11T04:53:49Z

It fails for both bottled and built-from-source PHP 7.3 via Homebrew.

hulkur · 2018-12-11T08:39:18Z

As a workaround:

In php.ini set pcre.jit=0

Note comment below.

Majkl578 · 2018-12-11T14:00:37Z

@hulkur Please don't recommend people to disable JIT, report a bug to bugs.php.net instead and only suggest it as a temporary workaround. JIT is an important performance feature.

johnchendev · 2018-12-12T06:08:47Z

@bobthecow, Thanks for the workaround. However, I was not able to find the config file that you referenced.

It has something to do with forking / pcntl. I'm trying to sort it out. In the meantime, you can use PsySH by disabling pcntl support, by adding this to your config file:
return [
  'usePcntl' => false,
];

May I know how do you open this file and drop in the code you mentioned? Thanks.

Running Mac Mojave

dportalesr · 2018-12-12T06:46:44Z

May I know how do you open this file and drop in the code you mentioned? Thanks.

@johnchendev Try creating a file at ~/.config/psysh/config.php if not already there.

<?php
return [
  'usePcntl' => false,
];

That's it.

bobthecow · 2018-12-12T06:58:28Z

See also that whole page under the "your config file" link in my comment 😉

ruudk · 2018-12-27T16:46:15Z

@bobthecow Thanks for posting the issue here. I'm using a completely different package (Resque) that also forks and crashes on preg_match. Also on Homebrew Mojave. Is there an issue on the Homebrew repository already that tracks this?

bobthecow · 2018-12-27T17:06:51Z

Not that I know of. Wanna take it over there? :)

ruudk · 2018-12-27T17:15:40Z

Added issue @ Homebrew Homebrew/homebrew-core#35491

chapeupreto · 2019-05-02T22:14:06Z

Unfortunately, it's not working with PHP 7.3.5 installed via homebrew.

mallardduck · 2019-05-02T22:51:22Z

Just wanted to say I appreciate @bobthecow keeping this open, even tho at this point it seems clear to be a platform issue. The config based solution works as a 'fix', but the issue is pervasive beyond psysh so not a real/full solution.

Until the underlying issue is fixed then other applications and use cases will still be affected. Perhaps more important, it means that a development environment is even less similar to production environments.

akeebismail · 2019-06-03T09:07:28Z

As a workaround:

In php.ini set pcre.jit=0

Note comment below.

this solve the problem for now

ihorvorotnov · 2019-06-05T16:05:58Z

Brew's PHP 7.3.6 - still crashes. This fixes it.

miken32 · 2019-06-14T18:23:37Z

For the record, I had this problem with PHP 7.2.19 on MacOS Mojave – the suggested fix of disabling the pcntl extension in psysh config fixed it for me. And I don't use Homebrew at all.

mallardduck · 2019-06-14T18:26:43Z

@miken32 And you're on a Mac, PC, or Linux?

JacquesvanWyk · 2019-07-02T14:53:36Z

May I know how do you open this file and drop in the code you mentioned? Thanks.

@johnchendev Try creating a file at ~/.config/psysh/config.php if not already there.
<?php
return [
  'usePcntl' => false,
];
That's it.

That worked for me. Thank you

ngocphamm · 2019-07-07T11:25:44Z

It looks like this is fix with PHP 7.3.7 Homebrew. At least for me, I don't need the line in config.php file anymore.

welenofsky · 2019-07-08T17:20:31Z

It looks like this is fix with PHP 7.3.7 Homebrew. At least for me, I don't need the line in config.php file anymore.

I just tried upgrading from 7.3.5 -> 7.3.7 and it did not resolve the issue for me :(

mallardduck · 2019-07-08T18:05:01Z

Same issue as @welenofsky, not working after upgrading. I wonder if @ngocphamm has something setup differently on their machine?

ngocphamm · 2019-07-09T01:59:31Z

I'm not too sure. This is my .config/psysh/config.php. PHP was upgraded with brew upgrade (update all outdated brews in my system)

return array(
    'historySize' => 200,
    'eraseDuplicates' => true,
    //'usePcntl' => false,
);

mallardduck · 2019-07-09T12:40:44Z

@ngocphamm I wonder if it has something to do with other system configurations though. Like the Mac OS X version you're using, PCRE version, things like that maybe?

I'm also forgetting and wonder if this is isolated to Mac's or if it would also affect other Unix based systems?

ngocphamm · 2019-07-09T13:16:17Z

I'm using latest macOS 10.14.5, with both pcre and pcre2 installed via Homebrew, with version 8.43, and 10.33, respectively. And php actually uses pcre according to this

~ »  brew uses pcre --installed
cairo                 glib                  imagemagick           nginx                 shared-mime-info      zsh
ffmpeg                harfbuzz              libass                php                   the_silver_searcher
~ »  brew uses pcre2 --installed
fish                                                                ripgrep

welenofsky · 2019-07-09T19:53:30Z

I'm using latest macOS 10.14.5, with both pcre and pcre2 installed via Homebrew, with version 8.43, and 10.33, respectively. And php actually uses pcre according to this
~ »  brew uses pcre --installed
cairo                 glib                  imagemagick           nginx                 shared-mime-info      zsh
ffmpeg                harfbuzz              libass                php                   the_silver_searcher
~ »  brew uses pcre2 --installed
fish                                                                ripgrep

I am using the same macOS version (10.14.5) and same PCRE/PCRE2 versions as you listed. Wondering what the difference could be.

bobthecow · 2019-07-10T02:19:36Z

I'm also forgetting and wonder if this is isolated to Mac's or if it would also affect other Unix based systems?

It has been reported on Linux systems as well.

zeshan77 · 2019-10-02T07:52:40Z

Update: as discussed below, this is a bug in Homebrew/macOS/PHP/pcntl. It should really be worked around by disabling pcre.jit in your php.ini.

It has something to do with forking / pcntl. I'm trying to sort it out. In the meantime, you can use PsySH by disabling pcntl support, by adding this to your config file:
return [
  'usePcntl' => false,
];

It worked for me. Thanks for the workaround!

mk-conn · 2019-10-30T11:03:43Z

Just upgraded to PHP 7.3.11 and psysh is working again

ramsey · 2019-10-30T14:34:42Z

I can confirm the same. I do not need to set usePcntl to false when running psysh on PHP 7.3.11.

driesvints · 2019-10-30T19:27:32Z

Same for me. Seems to be finally fixed 👍

zymawy · 2019-10-30T20:20:00Z

Confirmed ! 🥇

chapeupreto · 2019-10-30T21:44:33Z

All good here (PHP 7.3.11)

welenofsky · 2019-10-31T03:23:53Z

Confirmed here as well!

bobthecow · 2019-12-01T07:42:49Z

Working for me as well.

I'm going to close this, but leave it pinned, so people can find it if they need to.

…S refer to bobthecow/psysh#540 (comment)

bobthecow added a commit that referenced this issue Dec 10, 2018

Test #540

3aa42df

ghost mentioned this issue Dec 10, 2018

Not working after upgrade to PHP 7.3.0 laravel/tinker#63

Closed

drbyte mentioned this issue Dec 15, 2018

Tinker shell closing itself on every command laravel/valet#687

Closed

ruudk mentioned this issue Dec 27, 2018

PHP 7.3 segfaults when forking and using preg_match Homebrew/homebrew-core#35491

Closed

6 tasks

jaikdean mentioned this issue May 8, 2019

Fatal error when using threads vimeo/psalm#1601

Closed

driesvints mentioned this issue Jun 24, 2019

App::environment() ignores APP_ENV when --env option is used on cli laravel/framework#28854

Closed

bobthecow pinned this issue Oct 23, 2019

bobthecow mentioned this issue Oct 23, 2019

Psy Shell dies on first input on OSX with PHP 7.3.10 #574

Closed

bobthecow closed this as completed Dec 1, 2019

bobthecow unpinned this issue Apr 10, 2020

Arul- added a commit to Arul-/RestlerApplication that referenced this issue Aug 17, 2020

Bringing back tinker command. If you have trouble running it on Mac O…

62f7d90

…S refer to bobthecow/psysh#540 (comment)

Not working after upgrading to PHP 7.3 #540

Not working after upgrading to PHP 7.3 #540

Comments

dportalesr commented Dec 8, 2018

GrahamCampbell commented Dec 8, 2018

GrahamCampbell commented Dec 8, 2018

dciancu commented Dec 8, 2018

dciancu commented Dec 8, 2018 • edited Loading

GrahamCampbell commented Dec 8, 2018

GrahamCampbell commented Dec 8, 2018

dciancu commented Dec 8, 2018

dportalesr commented Dec 9, 2018 • edited Loading

chapeupreto commented Dec 9, 2018

bobthecow commented Dec 9, 2018 • edited Loading

bobthecow commented Dec 10, 2018

dportalesr commented Dec 10, 2018

ghost commented Dec 10, 2018

chapeupreto commented Dec 10, 2018

bobthecow commented Dec 10, 2018

chapeupreto commented Dec 10, 2018

CQD commented Dec 10, 2018

bobthecow commented Dec 11, 2018

hulkur commented Dec 11, 2018 • edited Loading

Majkl578 commented Dec 11, 2018

johnchendev commented Dec 12, 2018

dportalesr commented Dec 12, 2018 • edited Loading

bobthecow commented Dec 12, 2018

ruudk commented Dec 27, 2018

bobthecow commented Dec 27, 2018

ruudk commented Dec 27, 2018

chapeupreto commented May 2, 2019

mallardduck commented May 2, 2019

akeebismail commented Jun 3, 2019

ihorvorotnov commented Jun 5, 2019 • edited Loading

miken32 commented Jun 14, 2019 • edited Loading

mallardduck commented Jun 14, 2019

JacquesvanWyk commented Jul 2, 2019

ngocphamm commented Jul 7, 2019

welenofsky commented Jul 8, 2019

mallardduck commented Jul 8, 2019

ngocphamm commented Jul 9, 2019

mallardduck commented Jul 9, 2019

ngocphamm commented Jul 9, 2019 • edited Loading

welenofsky commented Jul 9, 2019

bobthecow commented Jul 10, 2019

zeshan77 commented Oct 2, 2019

mk-conn commented Oct 30, 2019

ramsey commented Oct 30, 2019

driesvints commented Oct 30, 2019

zymawy commented Oct 30, 2019

chapeupreto commented Oct 30, 2019

welenofsky commented Oct 31, 2019

bobthecow commented Dec 1, 2019

dciancu commented Dec 8, 2018 •

edited

Loading

dportalesr commented Dec 9, 2018 •

edited

Loading

bobthecow commented Dec 9, 2018 •

edited

Loading

hulkur commented Dec 11, 2018 •

edited

Loading

dportalesr commented Dec 12, 2018 •

edited

Loading

ihorvorotnov commented Jun 5, 2019 •

edited

Loading

miken32 commented Jun 14, 2019 •

edited

Loading

ngocphamm commented Jul 9, 2019 •

edited

Loading