Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting flash ID #3

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Add support for setting flash ID #3

merged 1 commit into from
Jan 6, 2023

Conversation

bodgit
Copy link
Owner

@bodgit bodgit commented Jan 6, 2023

  • Extract the flash ID from the header.
  • Export the flash ID in the reader.
  • Change NewWriter to take variadic options, add the flash ID as an option as well as the formatting time.
  • Correctly set the update counters to +/- 1 in the directory and block allocation maps.
  • Initialise empty directory entries to all 0xff.

Fixes #1

@bodgit bodgit added the enhancement New feature or request label Jan 6, 2023
@bodgit bodgit self-assigned this Jan 6, 2023
@bodgit
Add support for setting flash ID
7141e7e 
* Extract the flash ID from the header.
* Export the flash ID in the reader.
* Change NewWriter to take variadic options, add the flash ID as an
  option as well as the formatting time.
* Correctly set the update counters to +/- 1 in the directory and block
  allocation maps.
* Initialise empty directory entries to all 0xff.
@bodgit bodgit merged commit 6260709 into main Jan 6, 2023
@bodgit bodgit deleted the flashid branch January 6, 2023 00:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3851636691

  • 112 of 128 (87.5%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.8%) to 77.423%
Changes Missing Coverage Covered Lines Changed/Added Lines %
writer.go 45 49 91.84%
memcard.go 20 32 62.5%
Totals Coverage Status
Change from base Build 3806622527: 8.8%
Covered Lines: 607
Relevant Lines: 784
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bodgit bodgit

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to set flash ID
2 participants
@bodgit @coveralls