Update RRB size table after draining in push_chunk #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
force-pushed
the
issue_74
branch
2 times, most recently
from
903f2ba to
a956d1a
Compare
|
not sure if it's ok to add |
When a chunk does not fully fit in a node, we drain as many elements from the chunk into the node and later push the leftover chunk to a sibling. This commit makes sure that the size field of the parent node is updated correctly. For dense nodes, we can simply add the number of drained elements to the size. If there is a size table, we add that number to the size entry corresponding to the current element and all entries to the right. Closes bodil#74
|
No, It looks very good otherwise, I'll merge and unbreak the build later. |
|
Oh, and you seem to have fixed all the bugs uncovered by the big integration test I wrote before the weekend. I think I owe you a beverage of your choice or some such. 😁👍 |
|
Cool! I'm happy to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a chunk does not fully fit in a node, we drain as many elements from the
chunk into the node and later push the leftover chunk to a sibling.
This commit makes sure that the size field of the parent node is updated
correctly. For dense nodes, we can simply add the number of drained elements to
the size. If there is a size table, we add that number to the size entry
corresponding to the current element and all entries to the right.
Closes #74