Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Discord scope join #3

Closed
bombitmanbomb opened this issue Sep 18, 2023 · 4 comments
Closed

[BUG] Discord scope join #3

bombitmanbomb opened this issue Sep 18, 2023 · 4 comments

Comments

@bombitmanbomb
Copy link

bombitmanbomb commented Sep 18, 2023 •
edited
Loading

In discord OAuth, scopes are expected to be Space separated (%20)
Current implementation uses Comma separation (%2C) exclusively and results in scope error response if multiple scopes are used.
bogeychan added a commit that referenced this issue Sep 18, 2023
@bogeychan
fix: space-delimited list of scopes #3
0b45084
@bogeychan
Copy link
Owner

Hi 👋

Thanks for your feedback. should be fixed in 0.0.12.

@bombitmanbomb
Copy link
Author

Much thanks!

@bombitmanbomb
Copy link
Author

Checked the change, Would that not break other providers?

Discord is a bit.. special

@bogeychan
Copy link
Owner

bogeychan commented Sep 18, 2023 •
edited
Loading

no, using spaces complies with the specification: RFC6749 Section 3.3.

This can be found in most provider docs too. I only used the library with Reddit so far. Reddit allows both space- and comma separated scopes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bombitmanbomb @bogeychan