Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical center alignment into DefaultMonthHeader #78

Merged

Conversation

jeongth9446
Copy link
Contributor

I think center vertical alignment is needed in DefaultMonthHeader.

@boguszpawlowski
Copy link
Owner

@jeongth9446 Sorry for making you wait this much time, I was on vacations. Thank you very much for your contribution, could you just add a screenshot with your change visible to the description of the PR?

@jeongth9446
Copy link
Contributor Author

Thank you for your interest in my PR.

There will be no problem with the default font size of most devices, but if the font size displayed changes, the alignment may be distorted.

below AS-IS is issue case.

AS-IS
image

TO-BE (adding verticalAlignment)
image

@boguszpawlowski boguszpawlowski merged commit 6a1b44a into boguszpawlowski:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants