Column widths, cookies keyring fixes #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculating text-width does not seem to work reliably on Linux and macOS. Closes #197.
Now we only need browser_cookie3 to find the cookie file, not 2 libraries. E.g. yt-dlp doesn't find the Firefox cookie on Ubuntu if installed with snap.
bohning
approved these changes
Jan 6, 2024
IOError doesn't necessarily indicate a permisison problem. E.g. it also includes FileNotFoundError, which in one case was caused by yt-dlp not being able to locate the cookie file. Also, catching all IOErrors (OSErrors) makes debugging harder. If we want to handle permission issues separately, we should instead handle the error when actually doing the file op, so we can be sure that's really the issue. This reverts commit c03f322.
bohning
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.