feat: Add configuration option whether to trash or delete files/dirs #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trashing files obviously doesn't delete them immediately. This causes issues when migrating large USDB databases (thousands of files in the trash bin and no space left on the disk). As a workaround, I suggest adding an optional environment variable `SYNCER_CLEANUP_DELETE_IMMEDIATELY` which, when set, deletes files and directories immediately instead of trashing them.
g3n35i5
force-pushed
the
feat/cleanup-immediately
branch
from
b65dd6c to
6b2fad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trashing files obviously doesn't delete them immediately. This causes issues when migrating large USDB databases (thousands of files in the trash bin and no space left on the disk).
As a workaround, I suggest adding an optional environment variable
SYNCER_CLEANUP_DELETE_IMMEDIATELYwhich, when set, deletes files and directories immediately instead of trashing them.