Context hook #326
Draft
Context hook #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hook 'SongLoaderContextDidFinish' that allows subscribers access to _Context.
Call the new 'SongLoaderContextDidFinish' hook with the _Context object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, sorry for not responding to #283 . I've had a busy couple of months.
I'd love to have the
_Contextavailable to an addon. This would allow access to theSongLoggerfor clearer logging. I'm not quite happy with the implementation I came up with, especially the name, however, it doesn't break the existing hook. An alternative would be to just change the existing hook fromUsdbSongto_Context, or to add an additionalSongLoggerargument. Of course, external access to_Contextisn't very clean, so refactoring_ContexttoContextwould be better if needed.A different point of discussion could be placing the call to
SongLoaderContextDidFinishbefore the files are moved to their final destination, i.e allowing addons to work within the temporary directories. It would probably make a bit more sense from a conceptual point of view if the addon intends to modify existing files. That would need to be communicated somehow though.Happy to have a discussion.