Fix usdb covers fallback

CHANGELOG.md

@@ -4,6 +4,7 @@
 - Add more fine-grained options for video container/codec selection.
 
 ## Fixes
+- Cover postprocessing parameters are ignored if USDB cover is downloaded as fallback.
 
 ## Features
 

src/usdb_syncer/resource_dl.py

@@ -177,8 +177,8 @@ def download_image(url: str, logger: Log) -> bytes | None:
         return None
     except requests.RequestException:
         logger.error(
-            f"Failed to retrieve {url}. The server may be down or your internet "
-            "connection is currently unavailable."
+            f"Failed to retrieve {url}. The URL might be invalid, the server may be "
+            "down or your internet connection is currently unavailable."
         )
         return None
     if reply.status_code in range(100, 399):
@@ -203,6 +203,7 @@ def download_and_process_image(
     details: SongDetails,
     kind: ImageKind,
     max_width: CoverMaxSize | None,
+    process: bool = True,
 ) -> Path | None:
     logger = song_logger(details.song_id)
     if not (img_bytes := download_image(url, logger)):
@@ -217,7 +218,8 @@ def download_and_process_image(
     with path.open("wb") as file:
         file.write(img_bytes)
 
-    _process_image(meta_tags, max_width, path)
+    if process:
+        _process_image(meta_tags, max_width, path)
     return path
 
 

src/usdb_syncer/song_loader.py

@@ -455,13 +455,13 @@ def _maybe_download_cover(ctx: _Context) -> None:
             return
     if ctx.details.cover_url:
         ctx.logger.warning("Falling back to small USDB cover.")
-        if _download_cover_url(ctx, ctx.details.cover_url):
+        if _download_cover_url(ctx, ctx.details.cover_url, process=False):
             return
     keep = " Keeping last resource." if ctx.out.cover.resource else ""
     ctx.logger.error(f"Failed to download cover!{keep}")
 
 
-def _download_cover_url(ctx: _Context, url: str) -> bool:
+def _download_cover_url(ctx: _Context, url: str, process: bool = True) -> bool:
     """True if download was successful (or is unnecessary)."""
     assert ctx.options.cover
     if ctx.out.cover.resource == url:
@@ -474,6 +474,7 @@ def _download_cover_url(ctx: _Context, url: str) -> bool:
         details=ctx.details,
         kind=resource_dl.ImageKind.COVER,
         max_width=ctx.options.cover.max_size,
+        process=process,
     ):
         ctx.out.cover.resource = url
         ctx.out.cover.new_fname = path.name

tests/integration/test_song_loader.py

@@ -31,6 +31,7 @@ def _download_and_process_image(
     details: Any,
     kind: ImageKind,
     max_width: Any,
+    process: bool = True,
 ) -> Path | None:
     path = target_stem.with_name(f"{target_stem.name} [{kind.value}].jpg")
     path.touch()