You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
This change is causing issues whereby "session" cookies are no longer created properly. "Session" cookies rely on the MaxAge == 0 when used in consumers like echo-session. Max-age means the following (copied from ipfans/echo-session/session.go lines 28-30):
MaxAge=0 means no 'Max-Age' attribute specified.
MaxAge<0 means delete cookie now, equivalently 'Max-Age: 0'.
MaxAge>0 means Max-Age attribute present and given in second
With this change, the code ends up setting an empty-valued cookie when a session-only (aka "Remember me" is unchecked) is desired.
715bb32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is causing issues whereby "session" cookies are no longer created properly. "Session" cookies rely on the MaxAge == 0 when used in consumers like echo-session. Max-age means the following (copied from ipfans/echo-session/session.go lines 28-30):
MaxAge=0 means no 'Max-Age' attribute specified.
MaxAge<0 means delete cookie now, equivalently 'Max-Age: 0'.
MaxAge>0 means Max-Age attribute present and given in second
With this change, the code ends up setting an empty-valued cookie when a session-only (aka "Remember me" is unchecked) is desired.