Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set size to 0 can't update component but set to 0px can do it #218

Closed
IronLu233 opened this issue Mar 22, 2018 · 3 comments · Fixed by #219
Closed

set size to 0 can't update component but set to 0px can do it #218

IronLu233 opened this issue Mar 22, 2018 · 3 comments · Fixed by #219

Comments

@IronLu233
Copy link

IronLu233 commented Mar 22, 2018

Overview of the problem

I'm using re-resizable 4.4.6

My browser is:
Chrome
I am sure this issue is not a duplicate?
Yes

Description

Steps to Reproduce

  1. Create a controlled Resizable component.
  2. Set the size to 0 (the size is a property in a state) .
  3. Component will not change it's size.
  4. Set the size to 0px.
  5. Component will update it's size.

Demo
https://codesandbox.io/s/kxyl8nr397

Expected behavior

component can resize to 0 with giving 0 or 0px

Actual behavior

component don't resize to 0

if this actually is a bug ,Can I pull a request for it?

@bokuweb
Copy link
Owner

bokuweb commented Mar 22, 2018

@IronLu233 Thanks for your report :) I'll do investigation.

@bokuweb
Copy link
Owner

bokuweb commented Mar 26, 2018

@IronLu233 fixed. Could you please try v4.4.7 ?

@IronLu233
Copy link
Author

It works well. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants