Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Div with __resizable_base__ SHOULD remain after component is unmounted #667

Closed
manuFL opened this issue Sep 1, 2020 · 3 comments
Closed
Labels

Comments

@manuFL
Copy link

manuFL commented Sep 1, 2020

Hi, I'm having issues related to the behaviour mentioned in issue #224

I think that resizable_base item should be removed upon unmounting only if there are not other siblings re-resizable components.

In my scenario, for example, I'm using percentage sizes with several re-resizable components; all of them are children of the same parent div. If I destroy one of them, all the resizes events are broken also for the others, due to resizable_base removal. If I then create a new component, it puts back the resizable_base and all is back working as it should.

My suggested fix is to check whether there are other mounted components before removing this important item.

Thank you in advance for your support, keep up the great job!

@bokuweb bokuweb added the bug label Sep 2, 2020
@manuFL
Copy link
Author

manuFL commented Sep 11, 2020

Hi, there is any ETA for the fix? Thank you in advance!

bokuweb added a commit that referenced this issue Sep 22, 2020
I changed to create base elemet if needed.
bokuweb added a commit that referenced this issue Sep 22, 2020
I changed to create base elemet if needed.
bokuweb added a commit that referenced this issue Sep 22, 2020
I changed to create base elemet if needed.
bokuweb added a commit that referenced this issue Sep 22, 2020
I changed to create base elemet if needed.
@bokuweb
Copy link
Owner

bokuweb commented Sep 22, 2020

@manuFL I changed to create base element when needed. Please try tv6.5.0

@manuFL
Copy link
Author

manuFL commented Sep 25, 2020

Seems to work great now, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants