fix: Move react/react-dom to be peerDependencies instead of devDependencies #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisu
changed the title
|
HI, any status on getting this merged? If you like I can file an issue. |
|
@francisu sorry for late. |
|
v6.7.0 published @francisu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
Using the Resizable component gets a compile error in typescript v4.0.3 when used with yarn 2 indicating the component is not setup correctly with props.
In addition, it's not possible to reference the component using the yarn 2 dependency mechanism because the react dependency is missing. This cannot be corrected by a yarn 2 "packageExtensions" because react and react-dom are incorrectly listed as devDependencies rather than peerDependencies.
Tradeoffs
None.
Testing Done
yarn test reported clean results. I also tried this (by publishing my own copy) with our code, and both the compile error and dependency problems were resolved.