Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref to definedProps #805

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add ref to definedProps #805

merged 1 commit into from
Apr 24, 2024

Conversation

jorgezreik
Copy link
Contributor

@jorgezreik jorgezreik commented Apr 24, 2024

Proposed solution

Fixes resizable field always being null in React 18.3.

After this React PR for 18.3, ref is included as a normal prop. Because of this, we detect ref as a user-provided prop and break our ref logic. This causes the resizable field of our Resizable component to always read null. To fix this, we add ref to our defined props to ensure that we do not consider it a user-provided prop.

Tradeoffs

There should be no negative effects from this change.

For all users with React < 18.3, it is impossible to pass ref in props as it is removed by React, so this change will not affect them. For all users with React >= 18.3, this will fix the behavior of ref in their resizable component.

Testing Done

Tested accessing the resizable field in both React 18.0 and 18.3. Both work!

@bokuweb
Copy link
Owner

bokuweb commented Apr 24, 2024

@jorgezreik Thanks!!!!!!!!!!!!

@bokuweb bokuweb merged commit 8a39a21 into bokuweb:master Apr 24, 2024
@bokuweb
Copy link
Owner

bokuweb commented Apr 24, 2024

@jorgezreik 6.9.16 published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants