Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
Fixes
resizable
field always beingnull
in React 18.3.After this React PR for 18.3,
ref
is included as a normal prop. Because of this, we detectref
as a user-provided prop and break our ref logic. This causes theresizable
field of our Resizable component to always readnull
. To fix this, we addref
to our defined props to ensure that we do not consider it a user-provided prop.Tradeoffs
There should be no negative effects from this change.
For all users with React < 18.3, it is impossible to pass
ref
inprops
as it is removed by React, so this change will not affect them. For all users with React >= 18.3, this will fix the behavior ofref
in their resizable component.Testing Done
Tested accessing the
resizable
field in both React 18.0 and 18.3. Both work!