Change the format of LIST for symlinks #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
force-pushed
the
symlink2
branch
3 times, most recently
from
1f4e917
to
2ae1ec8
Compare
For symlinks, print the target in the LIST output, like "link -> target". That matches the behavior of other ftp servers, like FreeBSD's ftpd and vsftpd.
This is a prerequisite for fixing a bug in cap-std
The read_link function refuses to return the value of a symlink if it's absolute. But read_link_contents will allow that.
|
@hannesdejager could you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For symlinks, print the target in the LIST output, like
"link -> target". That matches the behavior of other ftp servers, like
FreeBSD's ftpd and vsftpd.
See Also bytecodealliance/cap-std#354
Note: this PR must be merged after #504 . Its tests depend on that one.