Fix windows build #513
Merged
Fix windows build #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesdejager
force-pushed
the
hannes/fix-windows
branch
from
3bfc1b6
to
737ad1f
Compare
robklg
approved these changes
May 19, 2024
hannesdejager
force-pushed
the
hannes/fix-windows
branch
3 times, most recently
from
a377e0d
to
a0e2f29
Compare
The windows build got broken since it seems we introduced non-backwards compatible code during the Capsicum additions. In this commit I hide some of that code behind a '#[cfg(unix))' conditional. I also added CI builds for all supported platforms that will run in the context of pull requests.
hannesdejager
force-pushed
the
hannes/fix-windows
branch
from
a0e2f29
to
082953c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows build got broken since it seems we introduced non-backwards compatible code during the Capsicum additions.