Create custom unmarshaller for orders #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordcurrie
force-pushed
the
gc/fix_old_orders
branch
from
8197dc2 to
d40a393
Compare
- We noticed an issue where some older orders were being sent with line items that had their properties field set an empty JSON object rather than the expected array. This was causing an error when attempting to unmarshal.
gordcurrie
force-pushed
the
gc/fix_old_orders
branch
from
d40a393 to
c760d4a
Compare
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 32 32
Lines 1281 1306 +25
=======================================
+ Hits 1279 1304 +25
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
markstgodard
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with line items that had their properties field set an empty
JSON object rather than the expected array. This was causing
an error when attempting to unmarshal.